Update protoquill to latest build #14385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusaquilus
force-pushed
the
update_protoquill
branch
from
2a5c3ba to
6c4ddbb
Compare
deusaquilus
changed the title
|
Okay. Fixed and ready to go. |
deusaquilus
force-pushed
the
update_protoquill
branch
2 times, most recently
from
3b9ad9f to
160f866
Compare
deusaquilus
changed the title
|
This is ready to go now. |
deusaquilus
force-pushed
the
update_protoquill
branch
from
160f866 to
139d3fc
Compare
deusaquilus
force-pushed
the
update_protoquill
branch
from
139d3fc to
31b55fe
Compare
|
This is done. Please review. |
|
These updates have been incorporated into #14395 |
nicolasstucki
approved these changes
Feb 3, 2022
griggt
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProtoQuill community build is on a very, very old version, I would like to re-integrate with the latest code now since in my primary codebase I have replaced
EntityQuery.insert/updatewithinsertValueandupdateValue. Also, this means that changes in dotty-staging/protoquill@5ed25aa need to be undone. I hope this is alright.I added compile and scalatest-driven testing of quill-sql and quill-sql-tests which is a minimum of what is needed to verify quill functionality. Also, I added Test/compile for quill-cassandra since this module uses macros in it's own unique ways. These settings are internally controlled by Quill's
runCommunityBuildtask. I want to keep it that way so that quill community builds can be run on a quill CI independently of community-build infrastructure.